You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/20 21:13:14 UTC
[GitHub] [superset] codecov[bot] commented on pull request #20149: chore: switching out ConnectorRegistry references for DatasourceDAO
codecov[bot] commented on PR #20149:
URL: https://github.com/apache/superset/pull/20149#issuecomment-1133382381
# [Codecov](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20149](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aace9b8) into [master](https://codecov.io/gh/apache/superset/commit/56e96950c17ec65ef18cedfb2ed6591796a96cfc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56e9695) will **decrease** coverage by `12.07%`.
> The diff coverage is `53.12%`.
> :exclamation: Current head aace9b8 differs from pull request most recent head 6a85df3. Consider uploading reports for the commit 6a85df3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20149 +/- ##
===========================================
- Coverage 66.45% 54.38% -12.08%
===========================================
Files 1721 1721
Lines 64513 64516 +3
Branches 6806 6806
===========================================
- Hits 42875 35085 -7790
- Misses 19906 27699 +7793
Partials 1732 1732
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.59% <53.12%> (+0.01%)` | :arrow_up: |
| python | `57.63% <53.12%> (-25.00%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `49.43% <39.06%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | `53.57% <0.00%> (-1.79%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `35.14% <20.00%> (-42.25%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `60.07% <33.33%> (-35.26%)` | :arrow_down: |
| [superset/views/datasource/views.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS92aWV3cy5weQ==) | `51.64% <33.33%> (-45.02%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `47.10% <40.00%> (-28.87%)` | :arrow_down: |
| [superset/common/query\_object\_factory.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdF9mYWN0b3J5LnB5) | `87.50% <60.00%> (ø)` | |
| [superset/cachekeys/api.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2FjaGVrZXlzL2FwaS5weQ==) | `52.83% <66.66%> (-43.33%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `34.28% <66.66%> (-62.78%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `16.14% <66.66%> (-75.73%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `82.97% <66.66%> (+0.37%)` | :arrow_up: |
| ... and [284 more](https://codecov.io/gh/apache/superset/pull/20149/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [56e9695...6a85df3](https://codecov.io/gh/apache/superset/pull/20149?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org