You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/02/20 21:47:32 UTC
[GitHub] [ignite] antonovsergey93 opened a new pull request #7461:
IGNITE-12710 Extension log in rebuild indexes to search problems.
antonovsergey93 opened a new pull request #7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
URL: https://github.com/apache/ignite/pull/7461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov commented on a change in pull request #7461:
IGNITE-12710 Extension log in rebuild indexes to search problems.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
URL: https://github.com/apache/ignite/pull/7461#discussion_r400806708
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaIndexCachePartitionWorker.java
##########
@@ -227,7 +237,7 @@ private void processKey(KeyCacheObject key) throws IgniteCheckedException {
GridCacheEntryEx entry = cctx.cache().entryEx(key);
try {
- entry.updateIndex(rowFilter, clo);
+ entry.updateIndex(rowFilter, clo, indexCacheStat);
Review comment:
Looks like all of these 3 params can be squashed into single closure right here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ygerzhedovich commented on a change in pull request #7461:
IGNITE-12710 Extension log in rebuild indexes to search problems.
Posted by GitBox <gi...@apache.org>.
ygerzhedovich commented on a change in pull request #7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
URL: https://github.com/apache/ignite/pull/7461#discussion_r382440685
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaIndexCacheVisitorImpl.java
##########
@@ -157,8 +171,55 @@ public SchemaIndexCacheVisitorImpl(GridCacheContext cctx, SchemaIndexCacheFilter
throw e;
}
- if (fut != null)
- fut.get();
+ if (fut != null && stat != null) {
Review comment:
Before the change we were waiting complete compound future, now we can skip it. It looks strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov merged pull request #7461: IGNITE-12710
Extension log in rebuild indexes to search problems.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
URL: https://github.com/apache/ignite/pull/7461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] antonovsergey93 commented on a change in pull request
#7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
Posted by GitBox <gi...@apache.org>.
antonovsergey93 commented on a change in pull request #7461: IGNITE-12710 Extension log in rebuild indexes to search problems.
URL: https://github.com/apache/ignite/pull/7461#discussion_r400883637
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaIndexCachePartitionWorker.java
##########
@@ -227,7 +237,7 @@ private void processKey(KeyCacheObject key) throws IgniteCheckedException {
GridCacheEntryEx entry = cctx.cache().entryEx(key);
try {
- entry.updateIndex(rowFilter, clo);
+ entry.updateIndex(rowFilter, clo, indexCacheStat);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services