You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by zr...@apache.org on 2023/04/07 19:25:22 UTC

[trafficcontrol] branch master updated: Fix chromedriver_updater GHA (#7436)

This is an automated email from the ASF dual-hosted git repository.

zrhoffman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b6a8db8b8 Fix chromedriver_updater GHA (#7436)
0b6a8db8b8 is described below

commit 0b6a8db8b8d7b344af0700fd3fa96bacfb64579f
Author: Steve Hamrick <sh...@gmail.com>
AuthorDate: Fri Apr 7 13:25:16 2023 -0600

    Fix chromedriver_updater GHA (#7436)
    
    * Install node_modules before checking outdated
    
    * Wrong columns
    
    * woops
---
 .github/actions/chromedriver-updater/entrypoint.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/actions/chromedriver-updater/entrypoint.sh b/.github/actions/chromedriver-updater/entrypoint.sh
index 4f96e429b9..42c4c8cd34 100755
--- a/.github/actions/chromedriver-updater/entrypoint.sh
+++ b/.github/actions/chromedriver-updater/entrypoint.sh
@@ -35,16 +35,18 @@ do
 
   pushd "./$proj" > /dev/null
 
+  npm ci
+
   outdated=$(npm outdated | grep "chromedriver" || echo "" )
 
-  if [ "$outdated" = "" ]; then
+  if [[ -z $outdated ]]; then
     echo "$proj is up to date"
     popd > /dev/null
     continue
   fi
 
-  latest=$(echo $outdated | cut -d ' ' -f4)
-  wanted=$(echo $outdated | cut -d ' ' -f3)
+  latest=$(echo $outdated | awk '{print $4}' )
+  wanted=$(echo $outdated | awk '{print $3}' )
 
   npm i --save-dev "chromedriver@$latest" --ignore-scripts > /dev/null