[jira] Commented: (FELIX-1325) gogo doesn't report a command not found error unless an argument is supplied

["Derek Baum (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730398#action_12730398 ] 

Derek Baum commented on FELIX-1325:
-----------------------------------

Here's the patch to resolve as described:

svn diff src/main/java/org/apache/felix/gogo/runtime/shell/Closure.java
Index: src/main/java/org/apache/felix/gogo/runtime/shell/Closure.java
===================================================================
--- src/main/java/org/apache/felix/gogo/runtime/shell/Closure.java      (revision 793625)
+++ src/main/java/org/apache/felix/gogo/runtime/shell/Closure.java      (working copy)
@@ -166,6 +166,10 @@
                 {
                     return session.variables.remove(scmd);
                 }
+                else if (values.size() == 2)
+                {
+                    return assignment(scmd, values.get(1));
+                }
                 else
                 {
                     Object value = execute(values.get(1), values.subList(2, values.size()));

> gogo doesn't report a command not found error unless an argument is supplied
> ----------------------------------------------------------------------------
>
>                 Key: FELIX-1325
>                 URL: https://issues.apache.org/jira/browse/FELIX-1325
>             Project: Felix
>          Issue Type: Improvement
>          Components: Gogo
>            Reporter: Derek Baum
>            Assignee: Derek Baum
>            Priority: Minor
>
> 2009/7/13 Hiram Chirino <ch...@gmail.com> wrote:
>     But on related note... to the gogo developers: I would have expected a
>     command not found error when you type in a command that's not found.  This
>     seems to work fine if you pass an argument to a command.  It this a 'feature' or a bug?
> This is a 'feature', in that an undefined command silently returns itself, rather than an error.
> This is so that:
> > x = hello
> works; otherwise the assignment would fail, with a command not found error.
> Note: that
> > x = hello world
> will actually evaluate the 'hello' command with 'world' as an argument.
> > x = "hello world"
> tries to evaulate the 'hello world' command, which probably doesn't exist, so it falls back to returning the value, rather than unknown command.
> I think this can be simply resolved by avoiding re-evaluating an assignment with a single argument.
> This will mean that
> > x = hello
> works as it does currently, but that
> > hello
> will fail with 'unknown command', rather than simply return itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.