You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/03/27 11:39:55 UTC
[GitHub] [kyuubi] zwangsheng opened a new pull request, #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
zwangsheng opened a new pull request, #4621:
URL: https://github.com/apache/kyuubi/pull/4621
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Close #4618
`api/v1/admin/operations` add queryParams sessionHandle
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on a diff in pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #4621:
URL: https://github.com/apache/kyuubi/pull/4621#discussion_r1149986241
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -173,6 +175,10 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
val usersSet = users.split(",").toSet
operations = operations.filter(operation => usersSet.contains(operation.getSession.user))
}
+ if (StringUtils.isNotBlank(sessionHandle)) {
Review Comment:
Sure, i'll make a follow up PR fix those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
URL: https://github.com/apache/kyuubi/pull/4621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #4621:
URL: https://github.com/apache/kyuubi/pull/4621#issuecomment-1484991013
cc @pan3793 @turboFei @lightning-L
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4621:
URL: https://github.com/apache/kyuubi/pull/4621#issuecomment-1486087269
There is room for performance improvement but is good to get in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on a diff in pull request #4621: [KYUUBI #4618][REST] Admin Resource list operations with sessionHandle filter
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #4621:
URL: https://github.com/apache/kyuubi/pull/4621#discussion_r1149971003
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -173,6 +175,10 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
val usersSet = users.split(",").toSet
operations = operations.filter(operation => usersSet.contains(operation.getSession.user))
}
+ if (StringUtils.isNotBlank(sessionHandle)) {
Review Comment:
Agree with @pan3793 , we can refactor this method to improve performance.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -160,7 +160,9 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
"get the list of all active operations")
Review Comment:
Please update the API description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org