You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2011/06/27 01:35:47 UTC
[jira] [Created] (LUCENE-3244) Contrib/Module-uptodate assume name
matches path and jar
Contrib/Module-uptodate assume name matches path and jar
--------------------------------------------------------
Key: LUCENE-3244
URL: https://issues.apache.org/jira/browse/LUCENE-3244
Project: Lucene - Java
Issue Type: Bug
Components: general/build
Reporter: Chris Male
With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055260#comment-13055260 ]
Robert Muir commented on LUCENE-3244:
-------------------------------------
just a thought: should we have a queries contrib and a queries module?
Can the "good" stuff in the queries contrib move to the module, and the "sandbox" stuff (if any) go somewhere else?!
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055280#comment-13055280 ]
Chris Male commented on LUCENE-3244:
------------------------------------
Thanks Robert!
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3244) Contrib/Module-uptodate
assume name matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055269#comment-13055269 ]
Chris Male edited comment on LUCENE-3244 at 6/27/11 1:11 AM:
-------------------------------------------------------------
Absolutely. I intended to do that after I had resolved the FunctionQuery moving (as its a dependency for many other issues). Would you guys prefer I do that and not make this change? Or are you okay with this change as well?
was (Author: cmale):
Absolutely. I intended to do that afterward I had resolved the FunctionQuery moving (as its a dependency for many other issues). Would you guys prefer I do that and not make this change? Or are you okay with this change as well?
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055274#comment-13055274 ]
Robert Muir commented on LUCENE-3244:
-------------------------------------
i think you should make this change and proceed forward!
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3244) Contrib/Module-uptodate assume name
matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-3244:
-------------------------------
Attachment: LUCENE-3244.patch
Patch adds contrib-src-name attribute to contrib-uptodate. This allows the name of the src for the contrib to be different to the contrib's project name.
The name attribute is now assumed to be the project name.
If the contrib-src-name property is omitted, name is used.
I have code that makes use of this (in changing the queries contrib to queries-contrib) and have verified it works.
I'd be great if someone could review this to see any implications I might have missed.
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3244) Contrib/Module-uptodate assume name
matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved LUCENE-3244.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Committed revision 1139989.
I'm going to leave module-uptodate alone till there is a need to change it.
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055279#comment-13055279 ]
Robert Muir commented on LUCENE-3244:
-------------------------------------
I committed a tiny fix, a ${name} -> @{name}
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055284#comment-13055284 ]
Chris Male commented on LUCENE-3244:
------------------------------------
Murphy's law, I needed to fix module-uptodate.
Committed revision 1139996.
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055239#comment-13055239 ]
Chris Male commented on LUCENE-3244:
------------------------------------
Actually I now see the ability to set the full jarfile in the contrib-uptodate macro. I still want to avoid this, since it requires the invoker of the macro to know the full path.
Instead I think having an optional 'project-name' property will suffice.
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055265#comment-13055265 ]
Steven Rowe commented on LUCENE-3244:
-------------------------------------
bq. Can the "good" stuff in the queries contrib move to the module, and the "sandbox" stuff (if any) go somewhere else?!
+1
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3244) Contrib/Module-uptodate assume
name matches path and jar
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055269#comment-13055269 ]
Chris Male commented on LUCENE-3244:
------------------------------------
Absolutely. I intended to do that afterward I had resolved the FunctionQuery moving (as its a dependency for many other issues). Would you guys prefer I do that and not make this change? Or are you okay with this change as well?
> Contrib/Module-uptodate assume name matches path and jar
> --------------------------------------------------------
>
> Key: LUCENE-3244
> URL: https://issues.apache.org/jira/browse/LUCENE-3244
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Chris Male
> Attachments: LUCENE-3244.patch
>
>
> With adding a new 'queries' module, I am trying to change the project name of contrib/queries to queries-contrib. However currently the contrib-uptodate assumes that the name property is used in the path and in the jar name.
> By using the name in the path, I must set the value to 'queries' (since the path is contrib/queries). However because the project name is now queries-contrib, the actual jar file will be lucene-queries-contrib-${version}.jar, not lucene-queries-${version}.jar, as is expected.
> Consequently I think we need to separate the path name from the jar name properties. For simplicity I think adding a new jar-name property will suffice, which can be optional and if omitted, is filled in with the name property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org