[PATCH] Re: svn commit: r1145972 - in /subversion/trunk/subversion: libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c svn/changelist-cmd.c tests/cmdline/changelist_tests.py tests/cmdline/tree_conflict_tests.py

[Noorul Islam K M <no...@collab.net>]

Noorul Islam K M <no...@collab.net> writes:

> rhuijben@apache.org writes:
>
>>    if (changelist_name)
>>      {
>> -      return svn_cl__try
>> -              (svn_client_add_to_changelist(targets, changelist_name,
>> +      SVN_ERR(svn_cl__try(
>> +               svn_client_add_to_changelist(targets, changelist_name,
>>                                              depth, opt_state->changelists,
>>                                              ctx, pool),
>> -               NULL, opt_state->quiet,
>> +               &success, opt_state->quiet,
>>                 SVN_ERR_UNVERSIONED_RESOURCE,
>>                 SVN_ERR_WC_PATH_NOT_FOUND,
>> -               SVN_NO_ERROR);
>> +               SVN_NO_ERROR));
>>      }
>>    else
>>      {
>> -      return svn_cl__try
>> -              (svn_client_remove_from_changelists(targets, depth,
>> +      SVN_ERR(svn_cl__try(
>> +               svn_client_remove_from_changelists(targets, depth,
>>                                                    opt_state->changelists,
>>                                                    ctx, pool),
>> -               NULL, opt_state->quiet,
>> +               &success, opt_state->quiet,
>>                 SVN_ERR_UNVERSIONED_RESOURCE,
>>                 SVN_ERR_WC_PATH_NOT_FOUND,
>> -               SVN_NO_ERROR);
>> +               SVN_NO_ERROR));
>>      }
>> +
>> +  if (!success)
>> +    return svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
>> +                            _("Could not display info for all targets because "
>> +                              "some targets don't exist"));
>
> I think this should be something like this. 
>
> Could not add all targets to changelist because some targets don't exist
>
> I will add test cases for handling multiple targets.
>

Log

[[[
* subversion/svn/changelist-cmd.c
  (svn_cl__changelist): Tweak error message. Also display different
    error message for add and remove.

* subversion/tests/cmdline/changelist_tests.py
  (mix_existing_and_non_existent_target): New test, verify that svn cl
    errors out in desirable way if mixture for existing and non-existent
    targets are passed. 
  (test_list): Add new test.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Thanks and Regards
Noorul