[GitHub] lzbj commented on a change in pull request #541: Add strict flag for user defined runtime.

[gi...@git.apache.org]

lzbj commented on a change in pull request #541: Add strict flag for user defined runtime.
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/541#discussion_r140680839
 
 

 ##########
 File path: parsers/manifest_parser.go
 ##########
 @@ -389,14 +389,14 @@ func (dm *YAMLParser) ComposeActions(filePath string, actions map[string]Action,
 		if action.Runtime != "" {
 			if utils.CheckExistRuntime(action.Runtime, utils.Rts) {
 				wskaction.Exec.Kind = action.Runtime
-			} else {
-				errStr := wski18n.T("the runtime is not supported by Openwhisk platform.\n")
-				whisk.Debug(whisk.DbgWarn, errStr)
-			}
-		} else {
-			errStr := wski18n.T("wskdeploy has chosen a particular runtime for the action.\n")
-			whisk.Debug(whisk.DbgWarn, errStr)
-		}
+
+			} else if utils.Flags.Strict {
+                wskaction.Exec.Kind = action.Runtime
+            } else {
+                errStr := wski18n.T("wskdeploy has chosen a particular runtime for the action.\n")
 
 Review comment:
   @houshengbo , thanks for your review, I think this message has already been there, and corresponding resource file are regenerated.
   https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/wski18n/resources/en_US.all.json#L55
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services