[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #24537: Add metadata module

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on code in PR #24537:
URL: https://github.com/apache/shardingsphere/pull/24537#discussion_r1132158787


##########
kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/factory/ExternalMetaDataFactory.java:
##########
@@ -72,7 +71,7 @@ public static Map<String, ShardingSphereDatabase> create(final Map<String, Datab
     private static Map<String, ShardingSphereDatabase> createGenericDatabases(final Map<String, DatabaseConfiguration> databaseConfigMap, final DatabaseType protocolType,
                                                                               final ConfigurationProperties props, final InstanceContext instanceContext) throws SQLException {
         Map<String, ShardingSphereDatabase> result = new HashMap<>(databaseConfigMap.size(), 1);
-        for (Entry<String, DatabaseConfiguration> entry : databaseConfigMap.entrySet()) {
+        for (Map.Entry<String, DatabaseConfiguration> entry : databaseConfigMap.entrySet()) {

Review Comment:
   Please remove `Map.`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org