You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/04/15 18:41:57 UTC

[GitHub] [madlib] kaknikhil commented on a change in pull request #368: DL: Add alternative options for compile params

kaknikhil commented on a change in pull request #368: DL: Add alternative options for compile params
URL: https://github.com/apache/madlib/pull/368#discussion_r275476957
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -516,8 +518,9 @@ def internal_keras_evaluate(x_test, y_test, model_arch, model_data, input_shape,
     model.set_weights(model_weights)
     optimizers = get_optimizers()
     (opt_name,final_args,compile_dict) = parse_compile_params(compile_params)
 
 Review comment:
   We can encapsulate lines 519 - 523 in a function which can then be called from other places as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services