[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1065451525


##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
         return null;
     }
 
-    public String allowOutgoingOnPrivate(String destCidr) {
+    public synchronized String allowOutgoingOnPrivate(String destCidr) {

Review Comment:
   ```suggestion
       /**
       * allow *only one* setting of an outgoing destination at a time
       *
       * @destCidr the destination network that will be allowed for outgoing traffic.
       * @return any error message that might be helpful or <null> on success or when called anywhere but in the router VM.
       */
       public synchronized String allowOutgoingOnPrivate(String destCidr) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org