Re: [PR] Add auto-complete flag to LineageEntry [pinot]

["krishan1390 (via GitHub)" <gi...@apache.org>]

krishan1390 commented on code in PR #18584:
URL: https://github.com/apache/pinot/pull/18584#discussion_r3346278841


##########
pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineage.java:
##########
@@ -171,7 +176,11 @@ public ZNRecord toZNRecord() {
       String segmentsTo = String.join(COMMA_SEPARATOR, lineageEntry.getSegmentsTo());
       String state = lineageEntry.getState().toString();
       String timestamp = Long.toString(lineageEntry.getTimestamp());
-      List<String> listEntry = Arrays.asList(segmentsFrom, segmentsTo, state, timestamp);
+      // Omit the 5th element when the flag is the default (false): keeps the wire format
+      // identical to legacy 4-tuples for every entry that does not opt into observer-driven
+      // completion, so older readers continue to parse them.
+      List<String> listEntry = lineageEntry.isAutoCompleteLineageEntry() ? Arrays.asList(segmentsFrom, segmentsTo,

Review Comment:
   That is fine and expected. We will only enable features to use this flag after the rollout is successful and we don't rollback. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org