You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/12 15:14:04 UTC

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #12610: [Improvement #12471] Migrate all dqrule-related interface functions from ProcessServiceImpl

codecov-commenter commented on PR #12610:
URL: https://github.com/apache/dolphinscheduler/pull/12610#issuecomment-1312503191

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/12610?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12610](https://codecov.io/gh/apache/dolphinscheduler/pull/12610?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ecde64) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/87a88e36627017607c73cfc66a92be08d1da22ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87a88e3) will **decrease** coverage by `0.02%`.
   > The diff coverage is `18.60%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev   #12610      +/-   ##
   ============================================
   - Coverage     39.27%   39.25%   -0.03%     
   + Complexity     4231     4230       -1     
   ============================================
     Files          1051     1057       +6     
     Lines         39849    39826      -23     
     Branches       4585     4567      -18     
   ============================================
   - Hits          15652    15633      -19     
   - Misses        22422    22423       +1     
   + Partials       1775     1770       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/12610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...r/dao/repository/impl/DqRuleInputEntryDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcVJ1bGVJbnB1dEVudHJ5RGFvSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...server/master/utils/DataQualityResultOperator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci91dGlscy9EYXRhUXVhbGl0eVJlc3VsdE9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nscheduler/service/process/ProcessServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZUltcGwuamF2YQ==) | `29.86% <ø> (+0.39%)` | :arrow_up: |
   | [...er/dao/repository/impl/DqExecuteResultDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcUV4ZWN1dGVSZXN1bHREYW9JbXBsLmphdmE=) | `5.00% <5.00%> (ø)` | |
   | [.../repository/impl/DqTaskStatisticsValueDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcVRhc2tTdGF0aXN0aWNzVmFsdWVEYW9JbXBsLmphdmE=) | `33.33% <33.33%> (ø)` | |
   | [...r/server/master/runner/task/BaseTaskProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvdGFzay9CYXNlVGFza1Byb2Nlc3Nvci5qYXZh) | `17.66% <42.85%> (+0.93%)` | :arrow_up: |
   | [...r/dao/repository/impl/DqComparisonTypeDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcUNvbXBhcmlzb25UeXBlRGFvSW1wbC5qYXZh) | `50.00% <50.00%> (ø)` | |
   | [...inscheduler/dao/repository/impl/DqRuleDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcVJ1bGVEYW9JbXBsLmphdmE=) | `50.00% <50.00%> (ø)` | |
   | [...r/dao/repository/impl/DqRuleExecuteSqlDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9EcVJ1bGVFeGVjdXRlU3FsRGFvSW1wbC5qYXZh) | `50.00% <50.00%> (ø)` | |
   | [...r/plugin/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS9kb2xwaGluc2NoZWR1bGVyLXJlZ2lzdHJ5LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3JlZ2lzdHJ5L3pvb2tlZXBlci9ab29rZWVwZXJSZWdpc3RyeS5qYXZh) | `43.54% <0.00%> (-6.46%)` | :arrow_down: |
   | ... and [27 more](https://codecov.io/gh/apache/dolphinscheduler/pull/12610/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org