You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by vj...@apache.org on 2020/06/20 17:21:50 UTC
[hbase] branch branch-2 updated: HBASE-23126: Removing the un-used
integration test class - IntegrationTestRSGroup
This is an automated email from the ASF dual-hosted git repository.
vjasani pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new 0527c2c HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
0527c2c is described below
commit 0527c2c70d743fa845db138ec255f21c5d65d839
Author: Sandeep Pal <50...@users.noreply.github.com>
AuthorDate: Sat Jun 20 22:48:39 2020 +0530
HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
Closes #1936
Signed-off-by: Duo Zhang <zh...@apache.org>
Signed-off-by: Jan Hentschel <ja...@ultratendency.com>
Signed-off-by: Viraj Jasani <vj...@apache.org>
---
.../hbase/rsgroup/IntegrationTestRSGroup.java | 103 ---------------------
1 file changed, 103 deletions(-)
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java
deleted file mode 100644
index f5f2ff9..0000000
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java
+++ /dev/null
@@ -1,103 +0,0 @@
-/**
- * Copyright The Apache Software Foundation
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.hadoop.hbase.rsgroup;
-
-import org.apache.hadoop.hbase.HConstants;
-import org.apache.hadoop.hbase.IntegrationTestingUtility;
-import org.apache.hadoop.hbase.Waiter;
-import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
-import org.apache.hadoop.hbase.testclassification.IntegrationTests;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.experimental.categories.Category;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-/**
- * Runs all of the units tests defined in TestGroupBase as an integration test.
- * Requires TestRSGroupBase.NUM_SLAVE_BASE servers to run.
- */
-@Category(IntegrationTests.class)
-public class IntegrationTestRSGroup extends TestRSGroupsBase {
- private final static Logger LOG = LoggerFactory.getLogger(IntegrationTestRSGroup.class);
- private static boolean initialized = false;
-
- @Before
- public void beforeMethod() throws Exception {
- if(!initialized) {
- LOG.info("Setting up IntegrationTestRSGroup");
- LOG.info("Initializing cluster with " + NUM_SLAVES_BASE + " servers");
- TEST_UTIL = new IntegrationTestingUtility();
- TEST_UTIL.getConfiguration().set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,
- RSGroupBasedLoadBalancer.class.getName());
- TEST_UTIL.getConfiguration().set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,
- RSGroupAdminEndpoint.class.getName());
- ((IntegrationTestingUtility)TEST_UTIL).initializeCluster(NUM_SLAVES_BASE);
- //set shared configs
- admin = TEST_UTIL.getAdmin();
- cluster = TEST_UTIL.getHBaseClusterInterface();
- rsGroupAdmin = new VerifyingRSGroupAdminClient(new RSGroupAdminClient(TEST_UTIL.getConnection()),
- TEST_UTIL.getConfiguration());
- LOG.info("Done initializing cluster");
- initialized = true;
- //cluster may not be clean
- //cleanup when initializing
- afterMethod();
- }
- }
-
- @After
- public void afterMethod() throws Exception {
- LOG.info("Cleaning up previous test run");
- //cleanup previous artifacts
- deleteTableIfNecessary();
- deleteNamespaceIfNecessary();
- deleteGroups();
- admin.setBalancerRunning(true, true);
-
- LOG.info("Restoring the cluster");
- ((IntegrationTestingUtility)TEST_UTIL).restoreCluster();
- LOG.info("Done restoring the cluster");
-
- TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {
- @Override
- public boolean evaluate() throws Exception {
- LOG.info("Waiting for cleanup to finish "+ rsGroupAdmin.listRSGroups());
- //Might be greater since moving servers back to default
- //is after starting a server
- return rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers().size()
- >= NUM_SLAVES_BASE;
- }
- });
-
- TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {
- @Override
- public boolean evaluate() throws Exception {
- LOG.info("Waiting for regionservers to be registered "+ rsGroupAdmin.listRSGroups());
- //Might be greater since moving servers back to default
- //is after starting a server
- return rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers().size()
- == getNumServers();
- }
- });
-
- LOG.info("Done cleaning up previous test run");
- }
-}