You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/21 14:12:43 UTC
[GitHub] [camel-quarkus] oscerd opened a new pull request #567: Create an
AWS common extension
oscerd opened a new pull request #567: Create an AWS common extension
URL: https://github.com/apache/camel-quarkus/pull/567
Fixes #566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568205519
Btw I'll move the extension when I can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #567:
Create an AWS commons extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#discussion_r360652004
##########
File path: tooling/package-maven-plugin/src/main/java/org/apache/camel/quarkus/maven/PrepareCatalogQuarkusMojo.java
##########
@@ -215,6 +215,7 @@ protected void appendOthers(List<CamelQuarkusExtension> extensions, CamelCatalog
final String title = ext.getName().orElseThrow(() -> new MojoExecutionException(
"name is missing in " + ext.getRuntimePomXmlPath()));
model.put("title", title);
+ System.err.println("title " + title + " and desc " + ext.getDescription());
Review comment:
Is this a leftover maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568201033
> I think the right place for this kind of ancillary extension would be `extensions/support/aws` and the artifactId should match the existing conventions - something like `camel-quarkus-support-aws`
Is there any reason not to move the extesion to `extensions/support/aws`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568204916
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/496/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568265383
Ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568189003
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568261117
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568286660
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/501/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568260057
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/498/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-tagsoup' /><a href='https://builds.apache.org/job/camel-quarkus-pr/498/org.apache.camel.quarkus$camel-quarkus-integration-test-tagsoup/testReport'>camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-tagsoup</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/camel-quarkus-pr/498/org.apache.camel.quarkus$camel-quarkus-integration-test-tagsoup/testReport/org.apache.camel.quarkus.component.tagsoup.it/TagSoupIT/htmlParse/'><strong>org.apache.camel.quarkus.component.tagsoup.it.TagSoupIT.htmlParse</strong></a></li></ul>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568302159
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/503/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #567:
Create an AWS commons extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#discussion_r360651976
##########
File path: extensions/aws-commons/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus AWS Commons"
+description: "A Camel Amazon Commons Component"
+metadata:
+ keywords:
Review comment:
```suggestion
unlisted: true
keywords:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568189069
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on a change in pull request #567:
Create an AWS commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#discussion_r360652281
##########
File path: tooling/package-maven-plugin/src/main/java/org/apache/camel/quarkus/maven/PrepareCatalogQuarkusMojo.java
##########
@@ -215,6 +215,7 @@ protected void appendOthers(List<CamelQuarkusExtension> extensions, CamelCatalog
final String title = ext.getName().orElseThrow(() -> new MojoExecutionException(
"name is missing in " + ext.getRuntimePomXmlPath()));
model.put("title", title);
+ System.err.println("title " + title + " and desc " + ext.getDescription());
Review comment:
Yes, my fault :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568247889
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #567: Create an AWS
commons extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #567: Create an AWS commons extension
URL: https://github.com/apache/camel-quarkus/pull/567#issuecomment-568201119
This was the first idea. It could be moved for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services