You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2017/04/07 06:00:23 UTC

Review Request 58260: AMBARI-20700 - UI should use the URL as-given by the backend

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58260/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Xi Wang.


Bugs: AMBARI-20700
    https://issues.apache.org/jira/browse/AMBARI-20700


Repository: ambari


Description
-------

Only overwrite urls if it is stack default, otherwise use url from /version_definition
Remove old diagnosis log.


Diffs
-----

  ambari-web/app/controllers/installer.js 369e163 


Diff: https://reviews.apache.org/r/58260/diff/1/


Testing
-------

Manually tested on live cluster.
All unit tests passed.
  20675 passing (21s)
  128 pending


Thanks,

Richard Zang


Re: Review Request 58260: AMBARI-20700 - UI should use the URL as-given by the backend

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58260/#review171626
-----------------------------------------------------------


Ship it!




Ship It!

- Xi Wang


On April 6, 2017, 11 p.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58260/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Xi Wang.
> 
> 
> Bugs: AMBARI-20700
>     https://issues.apache.org/jira/browse/AMBARI-20700
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Only overwrite urls if it is stack default, otherwise use url from /version_definition
> Remove old diagnosis log.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/installer.js 369e163 
> 
> 
> Diff: https://reviews.apache.org/r/58260/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20675 passing (21s)
>   128 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>