You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/25 12:07:00 UTC
[GitHub] [hive] fsilent opened a new pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
fsilent opened a new pull request #1816:
URL: https://github.com/apache/hive/pull/1816
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi merged pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
yongzhi merged pull request #1816:
URL: https://github.com/apache/hive/pull/1816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] fsilent closed pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
fsilent closed pull request #1816:
URL: https://github.com/apache/hive/pull/1816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] fsilent commented on a change in pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
fsilent commented on a change in pull request #1816:
URL: https://github.com/apache/hive/pull/1816#discussion_r553073159
##########
File path: spark-client/src/main/java/org/apache/hive/spark/client/AbstractSparkClient.java
##########
@@ -260,7 +265,7 @@ public void cancel(String jobId) {
if (!properties.setReadable(false) || !properties.setReadable(true, true)) {
throw new IOException("Cannot change permissions of job properties file.");
}
- properties.deleteOnExit();
+ sparkTmpProperties = properties;
Review comment:
Test result like this:
1. hive on spark task is running
Queue | Application Priority | StartTime | FinishTime | State | FinalStatus | Running Containers
-- | -- | -- | -- | -- | -- | --
Hive on Spark (sessionId = 5e75b839-0a66-45c6-bc98-4ea14befc267) | SPARK | default | 0 | Thu Jan 7 09:52:31 +0800 2021 | Thu Jan 7 N/A | RUNNING
2. spark tmp file in java.io.tmpdir(default is /tmp)
root@xxxx tmp]# ll spark*
-rw------- 1 xxx xxxx 37438 Jan 7 09:56 spark-submit.2308482618955056124.properties
3. beeline is finished
Hive on Spark (sessionId = 6228c803-55be-4c2a-9868-3deae7c432c3) | SPARK | default | 0 | Thu Jan 7 09:52:31 +0800 2021 | Thu Jan 7 09:54:04 +0800 2021 | FINISHED | SUCCEEDED
4. spark tmp file was deleted
[root@xxxx tmp]# ll spark*
ls: cannot access spark*: No such file or directory
5. if use kill -9 beeline pid, also can delete spark tmp file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi commented on a change in pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
yongzhi commented on a change in pull request #1816:
URL: https://github.com/apache/hive/pull/1816#discussion_r552943505
##########
File path: spark-client/src/main/java/org/apache/hive/spark/client/AbstractSparkClient.java
##########
@@ -260,7 +265,7 @@ public void cancel(String jobId) {
if (!properties.setReadable(false) || !properties.setReadable(true, true)) {
throw new IOException("Cannot change permissions of job properties file.");
}
- properties.deleteOnExit();
+ sparkTmpProperties = properties;
Review comment:
Is sparkTmpProperties only assigned when cancel called? Is there any normal scenario the properties need to be deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] fsilent commented on a change in pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
fsilent commented on a change in pull request #1816:
URL: https://github.com/apache/hive/pull/1816#discussion_r553061897
##########
File path: spark-client/src/main/java/org/apache/hive/spark/client/AbstractSparkClient.java
##########
@@ -260,7 +265,7 @@ public void cancel(String jobId) {
if (!properties.setReadable(false) || !properties.setReadable(true, true)) {
throw new IOException("Cannot change permissions of job properties file.");
}
- properties.deleteOnExit();
+ sparkTmpProperties = properties;
Review comment:
not only cancel, when spark driver stop include success finished and killed, both will be delete this applicationId tmp file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] fsilent commented on pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished
Posted by GitBox <gi...@apache.org>.
fsilent commented on pull request #1816:
URL: https://github.com/apache/hive/pull/1816#issuecomment-754522248
can someone review this pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org