[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6259: Broker time range pruning(#6189)

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #6259:
URL: https://github.com/apache/incubator-pinot/pull/6259#discussion_r521868067



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/PartitionSegmentPruner.java
##########
@@ -148,12 +149,12 @@ public synchronized void refreshSegment(String segment) {
   }
 
   @Override
-  public List<String> prune(BrokerRequest brokerRequest, List<String> segments) {
+  public Set<String> prune(BrokerRequest brokerRequest, Set<String> segments) {

Review comment:
       Let's see if the pruner code can deal with set v/s list as opposed to changing the APIs across all pruner users. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org