[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1377: CASSANDRA-17239 for cassandra-3.0

[GitBox <gi...@apache.org>]

josh-mckenzie commented on a change in pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377#discussion_r779638346



##########
File path: test/unit/org/apache/cassandra/db/compaction/CompactionExecutorTest.java
##########
@@ -63,44 +70,43 @@ public void destroy() throws Exception
         executor.awaitTermination(1, TimeUnit.MINUTES);
     }
 
+    void awaitExecution() throws Exception
+    {
+        assert afterExecuteCompleted.await(10, TimeUnit.SECONDS) : "afterExecute failed to complete";

Review comment:
       You inherited this from the initial implementation, but is there a reason we're only allowing for 10 seconds to execute before timing out? This seems like the kind of thing that could flake in adverse environments / scheduling / k8s silliness in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org