You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2022/10/20 00:24:20 UTC
[GitHub] [ambari] timyuer commented on a diff in pull request #3421: AMBARI-25763: Upgrade solr for BIGTOP to be compatible with bigtop-select
timyuer commented on code in PR #3421:
URL: https://github.com/apache/ambari/pull/3421#discussion_r1000036345
##########
ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/SOLR/package/scripts/params.py:
##########
@@ -84,6 +92,10 @@ def get_name_from_principal(principal):
# Only supporting SolrCloud mode - so hardcode those options
solr_cloudmode = 'true'
solr_dir = '/usr/lib/solr'
+
+if stack_version_formatted and check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_formatted):
+ solr_dir = format("{stack_root}/current/solr-server")
Review Comment:
That's a good reminder, but I found `stack_packages.json` has the map relation, should we obtain it from here?
e.g.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org