You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2023/12/06 08:20:15 UTC

[PR] [improve] [broker] Add logs for the checksum comparation [pulsar]

poorbarcode opened a new pull request, #21676:
URL: https://github.com/apache/pulsar/pull/21676

   ### Motivation
   
   Many users hit the issue `Failed to verify checksum`, see https://github.com/apache/pulsar/issues/21557
   
   https://github.com/apache/bookkeeper/pull/4140 tries to fix the bug of `Java9IntHash`, but @TinyQAQ said [the fix did not fix the issue they hit](https://github.com/apache/bookkeeper/pull/4140#issuecomment-1840692897).
   
   I want to add some logs to make it can be easier to analyze.
   
   ### Modifications
   
   - Add logs for the checksum comparison
   - A util class `VerboseLoggerThrottle` is used to avoid too many verbose logs to print. ZK's utility class([RateLogger](https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/RateLogger.java)) does not match our requirements, so we created this one.
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: x
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [improve] [broker] Add logs for the checksum comparation [pulsar]

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #21676:
URL: https://github.com/apache/pulsar/pull/21676#issuecomment-1842404758

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [improve] [broker] Add logs for the checksum comparation [pulsar]

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode closed pull request #21676: [improve] [broker] Add logs for the checksum comparation
URL: https://github.com/apache/pulsar/pull/21676


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org