You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by liyinan926 <gi...@git.apache.org> on 2015/08/28 22:40:44 UTC

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

GitHub user liyinan926 opened a pull request:

    https://github.com/apache/helix/pull/34

    Added new DataSource values LIVEINSTANCES and INSTANCES and made CriteriaEvaluator support them

    Currently there are two types of `DataSource`:  `EXTERNALVIEW` and `IDEALSTATES`. However, they don't work well with the task execution framework for which tasks as resources may come and go. An issue I noticed and also confirmed with @lei-xia and @kishoreg is broadcasting a user-defined message to a group of participants does not work since the `CriteriaEvaluator` selects nothing after evaluating a criteria that targets all participants. 
    
    This PR adds two new `DataSource` types: `LIVEINSTANCES` and `INSTANCES` and made `CriteriaEvaluator` support them.
     
    Signed-off-by: Yinan Li <li...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liyinan926/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 70962a0de5a58569e3f4f4d3f9533f540783db66
Author: Yinan Li <li...@gmail.com>
Date:   2015-08-28T20:33:04Z

    Added new DataSource values LIVEINSTANCES and INSTANCES and made CriteriaEvaluator support them
    
    Signed-off-by: Yinan Li <li...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: [HELIX-609] Added new DataSource values LIVEIN...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: [HELIX-609] Added new DataSource values LIVEIN...

Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the pull request:

    https://github.com/apache/helix/pull/34#issuecomment-138783773
  
    Thanks LGTM. Will apply the patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on the pull request:

    https://github.com/apache/helix/pull/34#issuecomment-138434746
  
    @kanakb @zzhang5 can one of you take a look at this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on the pull request:

    https://github.com/apache/helix/pull/34#issuecomment-138711514
  
    @kishoreg Updated 2a2908a.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the pull request:

    https://github.com/apache/helix/pull/34#issuecomment-138435680
  
    Looks good, can you add a simple test case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: [HELIX-609] Added new DataSource values LIVEIN...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on the pull request:

    https://github.com/apache/helix/pull/34#issuecomment-145173417
  
    @kishoreg just wondering when can you merge #34 and #35? Are they going into 0.7.2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---