[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5306: HBASE-27657: Connection and Request Attributes

["rmdmattingly (via GitHub)" <gi...@apache.org>]

rmdmattingly commented on code in PR #5306:
URL: https://github.com/apache/hbase/pull/5306#discussion_r1239816341


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcControllerImpl.java:
##########
@@ -166,6 +167,11 @@ public boolean hasCallTimeout() {
     return callTimeout != null;
   }
 
+  @Override
+  public Map<String, byte[]> getAttributes() {
+    return null;

Review Comment:
   Good point/question — this is done in a sense because the default controller won't provide any request attributes. I could think about whether there's a way to make the interface simpler here, so that rather than needing to provide a custom controller a user could just set some RequestHeaderProvider in the Configuration that's then called here. But I think that might be a little tricky and would add some significant amount of code that still, in its default form, has nothing to provide



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org