You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by keith2008 <gi...@git.apache.org> on 2016/08/23 01:22:21 UTC
[GitHub] trafficserver pull request #903: TS-4747: if the connection of parent is not...
GitHub user keith2008 opened a pull request:
https://github.com/apache/trafficserver/pull/903
TS-4747: if the connection of parent is notalive, not make the parent host down,which will select the the unavailablehost again
if the connection of parent is notalive, not make the parent host down,which will select the the unavailablehost again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith2008/trafficserver TS-4747
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #903
----
commit 8a76d21f5194cb31e514860319b8fcae2d2648be
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:42:30Z
TS-4743: parent use consistent_hash Strategy may cause crash while first parent is not set
commit 3deb52397b047455ba8aba3e5132e3daafa980ad
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:51:44Z
TS-4744: ParentConsistentHash::selectParent may select the unavailable parent
commit 49beaa5b5fd712c1d8383b081fc8479ec680ae0a
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:58:54Z
TS-4745: pRecord.failCount not init in ParentRecord::ProcessParents
commit 1159f47044e7add14ccaa84bf110895e244599b0
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T01:12:22Z
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak
commit 46671f91f337cd28dbc084dedde903382e3b3c38
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T01:17:40Z
TS-4747: if the connection of parent is notalive, not make the parent host down,which will select the the unavailablehost again
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #903: TS-4747: if the connection of parent is not...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford closed the pull request at:
https://github.com/apache/trafficserver/pull/903
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #903: TS-4747: if the connection of parent is notalive, ...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/903
Few issues here:
1) There are merge conflicts
2) Please don't bundle more than one Jira into each PR (unless absolutely necessary)
3) Squash commits to down to one, unless absolutely necessary to have multiple commits in the PR.
4) The Subject line of the commit message is too long, it should be < 50 characters to not get truncated (line wrapped) by Github. It's much nicer to have a short summary, and a longer description (after an empty line) in the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #903: TS-4747: if the connection of parent is notalive, ...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/903
Replacing this pull request with https://github.com/apache/trafficserver/pull/984 on behalf of @keith2008,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---