You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:57:09 UTC

[GitHub] [beam-wheels] ibzib commented on a change in pull request #17: Update README.md

ibzib commented on a change in pull request #17:
URL: https://github.com/apache/beam-wheels/pull/17#discussion_r430645550



##########
File path: README.md
##########
@@ -32,9 +32,11 @@ There are 2 major parts in this repository.
 * [travis](https://travis-ci.com/) configuration files, setups environment variables and deployment strategy.
   
   * `.travis.yml` contains a set of [environment variables](https://docs.travis-ci.com/user/environment-variables/) and steps of build process.
-  * `deploy_travis.sh` defines that final python wheels will be deployed to [dist.apache.org/dev](https://dist.apache.org/repos/dist/dev/beam/)
-    using svn with your apache credential.
   * `config.sh` defines custom build steps.
+  
+
+Additionally, for the release process to be complete:
+* Also use [sign_hash_python_wheel.sh](https://github.com/apache/beam/blob/master/release/src/main/scripts/sign_hash_python_wheels.sh) from the main beam repo in order to deploy the final python wheels to [dist.apache.org/dev](https://dist.apache.org/repos/dist/dev/beam/) using svn with your apache credential.

Review comment:
       ```suggestion
   * Also use [sign_hash_python_wheels.sh](https://github.com/apache/beam/blob/master/release/src/main/scripts/sign_hash_python_wheels.sh) from the main beam repo in order to deploy the final python wheels to [dist.apache.org/dev](https://dist.apache.org/repos/dist/dev/beam/) using svn with your apache credential.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org