You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "brusdev (via GitHub)" <gi...@apache.org> on 2026/04/28 09:54:29 UTC
[PR] Close connection factory [artemis]
brusdev opened a new pull request, #6389:
URL: https://github.com/apache/artemis/pull/6389
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] Close connection factory [artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr merged PR #6389:
URL: https://github.com/apache/artemis/pull/6389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] Close connection factory [artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #6389:
URL: https://github.com/apache/artemis/pull/6389#discussion_r3153368509
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/PerfClientCommand.java:
##########
@@ -122,7 +122,8 @@ protected void onExecuteBenchmark(final ConnectionFactory producerConnectionFact
boolean warmingUp = warmup != 0;
final LiveStatistics statistics;
final StringBuilder skratchBuffer = new StringBuilder();
- try (MessageListenerBenchmark consumerBenchmark = new MessageListenerBenchmarkBuilder()
+ try (ConnectionFactoryClosable consumerConnectionFactory = createConnectionFactory(listenerUrl, user, password, null, listenerProtocol);
+ MessageListenerBenchmark consumerBenchmark = new MessageListenerBenchmarkBuilder()
Review Comment:
The checkstyle check is failing because the MessageListenerBenchmark being on a new line means its indented more, so the following lines are tripping the check saying that they arent indented enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] Close connection factory [artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #6389:
URL: https://github.com/apache/artemis/pull/6389#discussion_r3153368509
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/PerfClientCommand.java:
##########
@@ -122,7 +122,8 @@ protected void onExecuteBenchmark(final ConnectionFactory producerConnectionFact
boolean warmingUp = warmup != 0;
final LiveStatistics statistics;
final StringBuilder skratchBuffer = new StringBuilder();
- try (MessageListenerBenchmark consumerBenchmark = new MessageListenerBenchmarkBuilder()
+ try (ConnectionFactoryClosable consumerConnectionFactory = createConnectionFactory(listenerUrl, user, password, null, listenerProtocol);
+ MessageListenerBenchmark consumerBenchmark = new MessageListenerBenchmarkBuilder()
Review Comment:
The checkstyle check is failing because the MessageListenerBenchmark being on a new line means its considered 'indented more', so the following lines are tripping the check saying that they arent indented enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org