You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/04 18:23:21 UTC

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #845: Display network type in network overview

rhtyd commented on a change in pull request #845:
URL: https://github.com/apache/cloudstack-primate/pull/845#discussion_r517544261



##########
File path: src/config/section/network.js
##########
@@ -29,7 +29,16 @@ export default {
       icon: 'apartment',
       permission: ['listNetworks'],
       resourceType: 'Network',
-      columns: ['name', 'state', 'type', 'cidr', 'ip6cidr', 'broadcasturi', 'account', 'zonename'],
+      columns: ['name', 'state',
+        {
+          type: (record) => {
+            if (record.vpcid && record.vpcid !== '') {
+              return 'VPC Tier'

Review comment:
       This is new, all VPC tiers are isolated networks - should this be changed in backend? I worry if it would confuse users.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org