[jira] [Resolved] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

["Randy Abernethy (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randy Abernethy resolved THRIFT-3786.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.10.0

great patch, thanks! committed with minor update to condition to support old nodes.

> Node.js TLS emits 'connect' before connection is ready
> ------------------------------------------------------
>
>                 Key: THRIFT-3786
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3786
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>            Reporter: James Reggio
>            Assignee: Randy Abernethy
>             Fix For: 0.10.0
>
>
> When using a TLS connection, the Node.js Thrift connection instance will emit a `connect` event early, making it possible to lose commands.
> `connect` is emitted by the Thrift connection instance when the underlying socket is opened, instead of when the TLS handshake has completed. Making matters worse, the offline queue is flushed during this premature `connect`, which means that any commands issued prior to the TLS connection handshake will be lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)