You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/09 19:48:30 UTC

[GitHub] [pulsar] HugoPelletier commented on a change in pull request #11595: [Python Schema] Fix redefined `Record` or `Enum` in Python schema

HugoPelletier commented on a change in pull request #11595:
URL: https://github.com/apache/pulsar/pull/11595#discussion_r685474487



##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -393,6 +413,9 @@ def python_type(self):
         return list
 
     def validate_type(self, name, val):
+        if val is None:
+            return None

Review comment:
       Should return the `self.default()`, not `None` automatically




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org