You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/02 13:48:43 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37773: [SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server
MaxGekk opened a new pull request, #37773:
URL: https://github.com/apache/spark/pull/37773
### What changes were proposed in this pull request?
In the PR, I propose:
1. Output errors in the PRETTY format in the same way as before the PR https://github.com/apache/spark/pull/37520.
2. Do not output non-JSON elements in the MINIMAL and STANDARD formats.
### Why are the changes needed?
1. To not break existing apps that might expect text errors in particular format.
3. Do not output extra text when the Thrift Server outputs errors in an JSON format.
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
By running the modified tests:
```
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *ThriftServerWithSparkContextInBinarySuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37773: [SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37773: [SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server
URL: https://github.com/apache/spark/pull/37773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37773: [SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37773:
URL: https://github.com/apache/spark/pull/37773#issuecomment-1235691023
Merging to master. Thank you, @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org