[GitHub] leakingoxide commented on issue #6452: [WiP] Add copy to clipboard button in Explore view

[GitBox <gi...@apache.org>]

leakingoxide commented on issue #6452: [WiP] Add copy to clipboard button in Explore view
URL: https://github.com/apache/incubator-superset/pull/6452#issuecomment-442279705
 
 
   oh, I didn't realize there's already a copy to clipboard button in the project... Then it'll be probably better to use some parts of it, instead of introducing another dependency.
   
   Personally, I like the idea of burying it, because as I understand now, we don't currently receive required data, and if the button was visible on the very first screen, then I'd just have to start a possibly long ajax call there. Putting it in the modal would allow me to postpone the loading until that modal is opened.
   
   Calling @hughhhh because he authored the issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org