You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/05 23:29:35 UTC
[GitHub] [arrow] maxburke opened a new pull request #7111: ARROW-8710: [rust] Ensure right order of messages written, and flush stream when complete.
maxburke opened a new pull request #7111:
URL: https://github.com/apache/arrow/pull/7111
The continuation marker needs to be written before the message byte
length, according to the Arrow specification.
Also for safety's sake the writer needs to be flushed once complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7111: ARROW-8710: [rust] Ensure right order of messages written, and flush stream when complete.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7111:
URL: https://github.com/apache/arrow/pull/7111#issuecomment-624359885
https://issues.apache.org/jira/browse/ARROW-8710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] maxburke commented on pull request #7111: ARROW-8710: [Rust] Ensure right order of messages written, and flush stream when complete.
Posted by GitBox <gi...@apache.org>.
maxburke commented on pull request #7111:
URL: https://github.com/apache/arrow/pull/7111#issuecomment-624407622
From the Rust docs on BufWriter:
> It is critical to call flush before BufWriter<W> is dropped. Though dropping will attempt to flush the the contents of the buffer, any errors that happen in the process of dropping will be ignored. Calling flush ensures that the buffer is empty and thus dropping will not even attempt file operations.
https://doc.rust-lang.org/std/io/struct.BufWriter.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org