You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/16 10:54:20 UTC
[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
GlenGeng opened a new pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428
## What changes were proposed in this pull request?
Say ozone.scm.names is `ip1,ip2,ip3`, scm with `ip1` identifies its RaftPeerId as `scm1`, scm with `ip2` identifies its RaftPeerId as `scm2`, scm with `ip3` identifies its RaftPeerId as `scm3`. They will automatically become a raft group.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4192
## How was this patch tested?
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] timmylicheng merged pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
timmylicheng merged pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-io commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report
> Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=desc) into [HDDS-2823](https://codecov.io/gh/apache/hadoop-ozone/commit/40127b3c2402a0cd279eded94764898a52a74c60?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `71.37%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## HDDS-2823 #1428 +/- ##
===============================================
- Coverage 73.36% 72.59% -0.77%
- Complexity 10166 10462 +296
===============================================
Files 994 1030 +36
Lines 50676 52575 +1899
Branches 4887 5008 +121
===============================================
+ Hits 37177 38167 +990
- Misses 11153 12003 +850
- Partials 2346 2405 +59
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/ratis/retrypolicy/RetryLimitedPolicyCreator.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9yYXRpcy9yZXRyeXBvbGljeS9SZXRyeUxpbWl0ZWRQb2xpY3lDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/hadoop/ozone/OzoneConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25maWdLZXlzLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `85.71% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...iner/common/transport/server/XceiverServerSpi.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvWGNlaXZlclNlcnZlclNwaS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `71.07% <ø> (-5.83%)` | `62.00 <0.00> (-5.00)` | |
| [...ache/hadoop/hdds/conf/DatanodeRatisGrpcConfig.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9jb25mL0RhdGFub2RlUmF0aXNHcnBjQ29uZmlnLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `74.77% <ø> (+0.90%)` | `20.00 <0.00> (+1.00)` | |
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `89.65% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2hhL1NDTUhBVXRpbHMuamF2YQ==) | `11.11% <ø> (-35.05%)` | `2.00 <0.00> (-4.00)` | |
| [...che/hadoop/hdds/scm/metadata/ContainerIDCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL21ldGFkYXRhL0NvbnRhaW5lcklEQ29kZWMuamF2YQ==) | `60.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [271 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=footer). Last update [0f64aab...ca9cb78](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report
> Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=desc) into [HDDS-2823](https://codecov.io/gh/apache/hadoop-ozone/commit/40127b3c2402a0cd279eded94764898a52a74c60?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `71.35%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## HDDS-2823 #1428 +/- ##
===============================================
- Coverage 73.36% 72.59% -0.77%
- Complexity 10166 10464 +298
===============================================
Files 994 1030 +36
Lines 50676 52574 +1898
Branches 4887 5008 +121
===============================================
+ Hits 37177 38167 +990
- Misses 11153 12005 +852
- Partials 2346 2402 +56
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/ratis/retrypolicy/RetryLimitedPolicyCreator.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9yYXRpcy9yZXRyeXBvbGljeS9SZXRyeUxpbWl0ZWRQb2xpY3lDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/hadoop/ozone/OzoneConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25maWdLZXlzLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `85.71% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...iner/common/transport/server/XceiverServerSpi.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvWGNlaXZlclNlcnZlclNwaS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `70.85% <ø> (-6.06%)` | `61.00 <0.00> (-6.00)` | |
| [...ache/hadoop/hdds/conf/DatanodeRatisGrpcConfig.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9jb25mL0RhdGFub2RlUmF0aXNHcnBjQ29uZmlnLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `74.77% <ø> (+0.90%)` | `20.00 <0.00> (+1.00)` | |
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `89.65% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2hhL1NDTUhBVXRpbHMuamF2YQ==) | `11.11% <ø> (-35.05%)` | `2.00 <0.00> (-4.00)` | |
| [...che/hadoop/hdds/scm/metadata/ContainerIDCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL21ldGFkYXRhL0NvbnRhaW5lcklEQ29kZWMuamF2YQ==) | `60.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [272 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=footer). Last update [138d33e...0dde979](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] timmylicheng commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
timmylicheng commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706478866
LGTM. +1. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report
> Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=desc) into [HDDS-2823](https://codecov.io/gh/apache/hadoop-ozone/commit/40127b3c2402a0cd279eded94764898a52a74c60?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `71.35%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## HDDS-2823 #1428 +/- ##
===============================================
- Coverage 73.36% 72.59% -0.77%
- Complexity 10166 10464 +298
===============================================
Files 994 1030 +36
Lines 50676 52574 +1898
Branches 4887 5008 +121
===============================================
+ Hits 37177 38167 +990
- Misses 11153 12005 +852
- Partials 2346 2402 +56
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/ratis/retrypolicy/RetryLimitedPolicyCreator.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9yYXRpcy9yZXRyeXBvbGljeS9SZXRyeUxpbWl0ZWRQb2xpY3lDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/hadoop/ozone/OzoneConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25maWdLZXlzLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `85.71% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...iner/common/transport/server/XceiverServerSpi.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvWGNlaXZlclNlcnZlclNwaS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `70.85% <ø> (-6.06%)` | `61.00 <0.00> (-6.00)` | |
| [...ache/hadoop/hdds/conf/DatanodeRatisGrpcConfig.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9jb25mL0RhdGFub2RlUmF0aXNHcnBjQ29uZmlnLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `74.77% <ø> (+0.90%)` | `20.00 <0.00> (+1.00)` | |
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `89.65% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2hhL1NDTUhBVXRpbHMuamF2YQ==) | `11.11% <ø> (-35.05%)` | `2.00 <0.00> (-4.00)` | |
| [...che/hadoop/hdds/scm/metadata/ContainerIDCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL21ldGFkYXRhL0NvbnRhaW5lcklEQ29kZWMuamF2YQ==) | `60.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [272 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=footer). Last update [138d33e...0dde979](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-io commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report
> Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=desc) into [HDDS-2823](https://codecov.io/gh/apache/hadoop-ozone/commit/40127b3c2402a0cd279eded94764898a52a74c60?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `71.37%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## HDDS-2823 #1428 +/- ##
===============================================
- Coverage 73.36% 72.59% -0.77%
- Complexity 10166 10462 +296
===============================================
Files 994 1030 +36
Lines 50676 52575 +1899
Branches 4887 5008 +121
===============================================
+ Hits 37177 38167 +990
- Misses 11153 12003 +850
- Partials 2346 2405 +59
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/ratis/retrypolicy/RetryLimitedPolicyCreator.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9yYXRpcy9yZXRyeXBvbGljeS9SZXRyeUxpbWl0ZWRQb2xpY3lDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/hadoop/ozone/OzoneConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25maWdLZXlzLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `85.71% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...iner/common/transport/server/XceiverServerSpi.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvWGNlaXZlclNlcnZlclNwaS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `71.07% <ø> (-5.83%)` | `62.00 <0.00> (-5.00)` | |
| [...ache/hadoop/hdds/conf/DatanodeRatisGrpcConfig.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9jb25mL0RhdGFub2RlUmF0aXNHcnBjQ29uZmlnLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `74.77% <ø> (+0.90%)` | `20.00 <0.00> (+1.00)` | |
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `89.65% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2hhL1NDTUhBVXRpbHMuamF2YQ==) | `11.11% <ø> (-35.05%)` | `2.00 <0.00> (-4.00)` | |
| [...che/hadoop/hdds/scm/metadata/ContainerIDCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL21ldGFkYXRhL0NvbnRhaW5lcklEQ29kZWMuamF2YQ==) | `60.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [271 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1428/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=footer). Last update [0f64aab...ca9cb78](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names
Posted by GitBox <gi...@apache.org>.
timmylicheng commented on a change in pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#discussion_r495538313
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java
##########
@@ -59,18 +68,62 @@
SCMRatisServerImpl(final SCMHAConfiguration haConf,
final ConfigurationSource conf)
throws IOException {
- final String scmServiceId = "SCM-HA-Service";
- final String scmNodeId = "localhost";
- this.raftPeerId = RaftPeerId.getRaftPeerId(scmNodeId);
+ // If the SCM group starts from OZONE_SCM_NAMES, its raft peers
+ // should locate on different nodes, and use the same port to
+ // communicate with each other.
+ //
+ // Assume ozone.scm.names is "ip0,ip1,ip2", scm with ip0 identifies
+ // its RaftPeerId as scm0, scm with ip1 identifies its RaftPeerId
+ // as scm1, scm with ip2 identifies its RaftPeerId as scm2. After
+ // startup, they will communicate with each other via
+ // ozone.scm.ha.ratis.bind.port, and form a raft group with
+ // groupID "SCM-HA-Service".
+ List<String> scmHosts =
+ Arrays.stream(conf.getTrimmedStrings(ScmConfigKeys.OZONE_SCM_NAMES))
+ .map(scmName -> HddsUtils.getHostName(scmName).get())
+ .collect(Collectors.toList());
+
this.address = haConf.getRatisBindAddress();
- final RaftPeer localRaftPeer = new RaftPeer(raftPeerId, address);
+ InetAddress localHost = InetAddress.getLocalHost();
+
+ int selfIndex = -1;
Review comment:
Could we move this self validation to an overall IP validation method so that we could throw in more validation once we are getting close to the ultimate HA config version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org