You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/04 08:19:05 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #8506: add parser support for SQL_MODE=ANSI_QUOTES
jingshanglu opened a new pull request #8506:
URL: https://github.com/apache/shardingsphere/pull/8506
Fixes #8505 .
Changes proposed in this pull request:
- add parser support for SQL_MODE=ANSI_QUOTES
- fix parser of `engin=INNODB`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #8506: add parser support for SQL_MODE=ANSI_QUOTES
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8506:
URL: https://github.com/apache/shardingsphere/pull/8506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8506: add parser support for SQL_MODE=ANSI_QUOTES
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8506:
URL: https://github.com/apache/shardingsphere/pull/8506#issuecomment-738663802
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=h1) Report
> Merging [#8506](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=desc) (cf8e437) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b3c6ea6c71eb0ba342a31d65f22f351fea7bc313?el=desc) (b3c6ea6) will **decrease** coverage by `0.44%`.
> The diff coverage is `70.45%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8506/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8506 +/- ##
============================================
- Coverage 73.25% 72.81% -0.45%
- Complexity 602 603 +1
============================================
Files 1521 1533 +12
Lines 24071 24291 +220
Branches 4241 4276 +35
============================================
+ Hits 17633 17687 +54
- Misses 5278 5437 +159
- Partials 1160 1167 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sql/visitor/format/impl/MySQLFormatSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9pbXBsL015U1FMRm9ybWF0U1FMVmlzaXRvci5qYXZh) | `48.89% <0.00%> (+1.46%)` | `0.00 <0.00> (ø)` | |
| [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `75.77% <72.09%> (-1.76%)` | `1.00 <0.00> (ø)` | |
| [...osition/resume/ResumeBreakPointManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL1Jlc3VtZUJyZWFrUG9pbnRNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `66.43% <0.00%> (-9.57%)` | `0.00% <0.00%> (ø%)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
| [...infra/rule/builder/ShardingSphereRulesBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvU2hhcmRpbmdTcGhlcmVSdWxlc0J1aWxkZXIuamF2YQ==) | `66.66% <0.00%> (-6.07%)` | `0.00% <0.00%> (ø%)` | |
| [...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh) | `88.23% <0.00%> (-5.52%)` | `0.00% <0.00%> (ø%)` | |
| [.../apache/shardingsphere/ha/algorithm/MGRHAType.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9hbGdvcml0aG0vTUdSSEFUeXBlLmphdmE=) | `4.10% <0.00%> (-0.44%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/shardingsphere/infra/state/StateContext.java](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zdGF0ZS9TdGF0ZUNvbnRleHQuamF2YQ==) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [43 more](https://codecov.io/gh/apache/shardingsphere/pull/8506/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=footer). Last update [b3c6ea6...cf8e437](https://codecov.io/gh/apache/shardingsphere/pull/8506?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org