You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2025/03/24 22:41:40 UTC
[PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
zabetak opened a new pull request, #5714:
URL: https://github.com/apache/hive/pull/5714
### What changes were proposed in this pull request?
Set the problematic alignment options to the value 16, which in Eclipse is mapped to:
Line wrapping policy: Wrap where necessary
Indentation policy: Default indentation
### Why are the changes needed?
To allow the code-style to work in recent versions of IntelliJ and Eclipse.
### Does this PR introduce _any_ user-facing change?
No, it only affects developpers and mostly those working in IntelliJ.
### Is the change a dependency upgrade?
No
### How was this patch tested?
Manual import of the new and old style in Eclipse 2025-03 (4.35.0) and IntelliJ IDEA 2024.3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #5714:
URL: https://github.com/apache/hive/pull/5714#issuecomment-2783363017
@zhangbutao The file is mentioned in the [contribution guidelines ](https://hive.apache.org/docs/latest/howtocontribute_27362107/) so it's good to keep it functional. Unfortunately we don't have an automated way to enforce the style at the moment so it's up to us to enforce it. Eventually, we should move to automation and uniform code style like every modern project :)
@soumyakanti3578 I didn't re trigger the tests because that would be just a waste of resources. The compaction failures were clearly unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on PR #5714:
URL: https://github.com/apache/hive/pull/5714#issuecomment-2755021238
Reproduced the issue and confirmed that the fix works on my laptop for IntelliJ IDEA 2024.3.4.1.
The fix looks good to me. Although the failing tests are not related to the patch, it's probably better to run them again before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5714:
URL: https://github.com/apache/hive/pull/5714#issuecomment-2749661025
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5714) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5714&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5714&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5714&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5714&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5714&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5714)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5714:
URL: https://github.com/apache/hive/pull/5714#issuecomment-2782683878
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5714) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5714&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5714&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5714&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5714&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5714&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5714)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4 [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #5714: HIVE-28847: Import of eclipse-styles.xml fails in IntelliJ IDEA 2024.3.4
URL: https://github.com/apache/hive/pull/5714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org