You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2011/04/07 01:36:07 UTC

[PATCH] yank explicit logging of current pid from WinNT MPM messages

because the lines have to be changed anyway to fix the format string,
and the pid is in the normal error log format anyway.  I left the
"Child:" prefix as it provides a useful context.

If somebody wants to keep the pid there because of ornery
custo^H^H^H^H^Husers who would not add it back to their custom error
log format when helpful, speak up.

Index: winnt/child.c
===================================================================
--- winnt/child.c       (revision 1089661)
+++ winnt/child.c       (working copy)
@@ -338,7 +338,7 @@
     }

     ap_log_error(APLOG_MARK, APLOG_INFO, 0, ap_server_conf,
-                 "Child %d: Accept thread listening on %s:%d using %s", my_pid,
+                 "Child: Accept thread listening on %s:%d using %s",
                  lr->bind_addr->hostname ? lr->bind_addr->hostname : "*",
                  lr->bind_addr->port, accf_name);

ad infinitum

Re: [PATCH] yank explicit logging of current pid from WinNT MPM messages

Posted by Eric Covener <co...@gmail.com>.
> and the pid is in the normal error log format anyway.

+1