[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

[yhuai <gi...@git.apache.org>]

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13868#discussion_r68441144
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with CatalystConf with Logging {
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
       def warehousePath: String = {
    -    getConf(WAREHOUSE_PATH).replace("${system:user.dir}", System.getProperty("user.dir"))
    +    new File(getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
    +      System.getProperty("user.dir"))).toURI.toString
    --- End diff --
    
    I am not sure it is the right fix. What will happen if a user's default fs is hdfs or s3 and he/she set `spark.sql.warehouse.dir` in the conf?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org