You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Jiaqing Guo <gu...@cn.ibm.com> on 2013/03/04 05:06:37 UTC
Re: Review Request: Do enhancement for FeatureRegistry to detect feature
dependency loop problem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7497/
-----------------------------------------------------------
(Updated March 4, 2013, 4:06 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Changes
-------
Fix comment from Ryan.
Description
-------
This patch is used to fix bug SHINDIG-1877.
It will do a enhancement for FeatureRegistry to detect feature dependency loop problem when it tries to complete dependency node graph for loaded feature node.
This addresses bug SHINDIG-1877.
https://issues.apache.org/jira/browse/SHINDIG-1877
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java 1452174
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java 1452174
Diff: https://reviews.apache.org/r/7497/diff/
Testing
-------
Thanks,
Jiaqing Guo
Re: Review Request: Do enhancement for FeatureRegistry to detect feature
dependency loop problem
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7497/#review17543
-----------------------------------------------------------
Ship it!
Committed revision 1453895
- Ryan Baxter
On March 4, 2013, 4:06 a.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7497/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 4:06 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> This patch is used to fix bug SHINDIG-1877.
> It will do a enhancement for FeatureRegistry to detect feature dependency loop problem when it tries to complete dependency node graph for loaded feature node.
>
>
> This addresses bug SHINDIG-1877.
> https://issues.apache.org/jira/browse/SHINDIG-1877
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java 1452174
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java 1452174
>
> Diff: https://reviews.apache.org/r/7497/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiaqing Guo
>
>