[GitHub] [incubator-ponymail] Humbedooh commented on pull request #517: Add DKIM style ID generation

[GitBox <gi...@apache.org>]

Humbedooh commented on pull request #517:
URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-672237119


   Isn't that just trading one potential risk (if you will) for another?
   If you keep *any* received headers in the permalink ID, you risk losing reproducibility in permalinks for emails that either don't have a list-id, or are sent via multiple lists.
   
   I think the DKIM list makes sense, and would trade the stable generated hash over whether or not you can debug ezmlm with it. 
   ezmlm's return path only applies if your email address is the direct recipient after the list was invoked. If it goes past that, you may lose it, and the index number will be lost anyway. I'm also unsure whether it's Pony Mail's job to debug whether postfix/etc received an email or not.
   
   Having said all that, what I could envision is for the next generation pony mail to use this generator for the permalink, but store multiple copies of the _source_, as they come in, and referencing them in a metadata table (or just storing the pibble in the source as well, but not use it for the document ID). When viewing the source, you could be presented with all existing options. Thus, you would have just the one copy of the email when viewing the list (which I think makes the most sense in any case), but multiple options when viewing the source.
   
   That is, to sum up, I like this generator and what it accomplishes - I think it looks far better than our previous/current solutions, and if not for this version, I'd be interested in pulling this PR into the next generation of pony mail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org