You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Freedman (JIRA)" <de...@myfaces.apache.org> on 2011/06/14 23:00:48 UTC

[jira] [Commented] (PORTLETBRIDGE-215) EncodeResource url improperly recognizes non context path encoded urls beginning with / as being an internal url

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049414#comment-13049414 ] 

Michael Freedman commented on PORTLETBRIDGE-215:
------------------------------------------------

Looks like ADF does the right thing and ensures anything starting with a / is transformed to a context path relative url via Viewhandler.getResourceURL().  I.e. GoLink impls that by the time encodeActionURL is called anything starting with a / is context path encoded -- whether this context path or another on the server.  So logically the bridge's encodeActionURL should check any url that begins with / and make sure its in this apps context path, if it is not then it should turn the url into an absolute url and return it.  Fix this as well.

> EncodeResource url improperly recognizes non context path encoded  urls beginning with / as being an internal url
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-215
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-215
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>            Reporter: Michael Freedman
>            Assignee: Michael Freedman
>
> If you have an url that is passed to encodeResourceUrl which begins /foo/bar.jpg  where /foo isn't this applications context-path, the bridge recognizes this url as a internal app url and prefixs it with the context-path.  However, because JSF doesn't do auto-context path appending the above url is invalid in regular (serlvet) JSF as its neither relative to the current page nor the current server.  Hence all resource urls that begin with / should be seen as external urls -- i.e. assumed to be urls that are full path (including the context-path) to another application in this server.
> As ADF's GoLink uses encodeActionUrl for its targets -- we should also review and consider correct behavior there as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira