You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/02/10 20:10:38 UTC
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/264
Update the CSS and some controls for the CORS page:
- the 'update' input field for editing a domain name, now automatically
resizes and no longer overlaps the pencil/trashcan buttons
- users can hit 'enter' to validate and submit the 'Update' domain and
'Add' domain fields
- page does not return an empty origin, if "specific origins" is set, but
there are no domains on that list
closes COUCHDB-2569
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton 2569-CORS-CSS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/264.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #264
----
commit 30657a05abd0575be441ce45a4ce835ceb74bfd3
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-02-06T20:47:56Z
Update the CSS and some controls for the CORS page:
- the 'update' input field for editing a domain name, now automatically
resizes and no longer overlaps the pencil/trashcan buttons
- users can hit 'enter' to validate and submit the 'Update' domain and
'Add' domain fields
- page does not return an empty origin, if "specific origins" is set, but
there are no domains on that list
closes COUCHDB-2569
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#discussion_r25352920
--- Diff: app/addons/cors/components.react.jsx ---
@@ -152,6 +158,12 @@ define([
this.setState({origin: ''});
},
+ onKeyUp: function (e) {
+ if (e.keyCode == 13 ) { //enter key
--- End diff --
same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#discussion_r25352900
--- Diff: app/addons/cors/components.react.jsx ---
@@ -69,11 +69,17 @@ define([
this.setState({updatedOrigin: event.target.value});
},
+ onKeyUp: function (e) {
+ if (e.keyCode == 13 ) { //enter key
--- End diff --
extra space after 13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-76026408
This way you always have the right properties already set on your model, no matter which way to get the value you use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#discussion_r24480945
--- Diff: app/addons/cors/components.react.jsx ---
@@ -232,7 +251,7 @@ define([
enableCorsChange: function (event) {
if (this.state.corsEnabled && !_.isEmpty(this.state.origins) && !this.state.isAllOrigins) {
- var result = window.confirm('Are you sure? Disabling CORS will overwrite your specific origin domains.');
+ var result = window.confirm('Are you sure? Disabling CORS will disable browser access to your databases from other applications.');
--- End diff --
I prefer the original message here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-76025227
hi michelle, the test is really cool but the way `parse` is used is not quite right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-73851522
Looking good @michellephung. Can you write a test for the "page does not return an empty origin, if "specific origins" is set, but there are no domains on that list" and can you fix the failing test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-74920816
@robertkowalski @garrensmith
I updated the onKeyDown to onKeyUp, per Robert's suggestion.
Still not sure if I did the test right. I moved the delete-empty-string-for-origin into cors/resources.js before we set the stores. So I moved the test into resourceSpec.js.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-76369463
merged as b29ad53cfc3df39dd91412ec01c54d75be6ceab6 - thank you michelle!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-74584038
test is working :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Update the CSS and some controls for...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/264#issuecomment-76025872
after the parse the (modified) contents from the server (empty string changed to an empty array: `[]`) the object is passed internally to something like a set which populates the properties on the model.
see also http://backbonejs.org/#Model-parse:
```
The function is passed the raw response object, and should return
the attributes hash to be set on the model.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---