You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "imlijinting (GitHub)" <gi...@apache.org> on 2018/08/25 04:22:34 UTC

[GitHub] [incubator-servicecomb-saga] imlijinting opened pull request #272: [SCB-865] Refactoring the Omega Interceptors

1.Remove the inheritance hierarchy between SagaStartAnnotationProcessor and EventAwareInterceptor.
2.Remove the NO_OP_INTERCEPTOR from the interface EventAwareInterceptor. Turning the NoOp Implementation into a class of static singleton pattern.
3.Removing parentId when dealing with error.


[ Full content available at: https://github.com/apache/incubator-servicecomb-saga/pull/272 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-saga] coveralls commented on issue #272: [SCB-865] Refactoring the Omega Interceptors

Posted by "coveralls (GitHub)" <gi...@apache.org>.
[![Coverage Status](https://coveralls.io/builds/18664047/badge)](https://coveralls.io/builds/18664047)

Coverage increased (+0.01%) to 93.642% when pulling **d611f6e8ffe5dc8cffc4c5eec3ece9651b588024 on imlijinting:SCB-865** into **95be0967a837db70bc623462162c3495b05ae2c2 on apache:master**.


[ Full content available at: https://github.com/apache/incubator-servicecomb-saga/pull/272 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-saga] WillemJiang commented on pull request #272: [SCB-865] Refactoring the Omega Interceptors

Posted by "WillemJiang (GitHub)" <gi...@apache.org>.
We need to add the license header here.

[ Full content available at: https://github.com/apache/incubator-servicecomb-saga/pull/272 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-saga] WillemJiang closed pull request #272: [SCB-865] Refactoring the Omega Interceptors

Posted by "WillemJiang (GitHub)" <gi...@apache.org>.
[ pull request closed by WillemJiang ]

[ Full content available at: https://github.com/apache/incubator-servicecomb-saga/pull/272 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-saga] WillemJiang commented on issue #272: [SCB-865] Refactoring the Omega Interceptors

Posted by "WillemJiang (GitHub)" <gi...@apache.org>.
@imlijinting  Don't worry, I just add the license header to the file.

[ Full content available at: https://github.com/apache/incubator-servicecomb-saga/pull/272 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org