You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/06/07 17:32:26 UTC

[kudu-CR] Java: fix git worktree compatibility 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7104

to review the following change.

Change subject: Java: fix git worktree compatibility
......................................................................

Java: fix git worktree compatibility

The .git file is not a directory in git worktree checkouts.

A similar issue was fixed in thirdparty in 21f5ae0d53f9e.

Change-Id: I7297b3a69ccfc0a9ce9db083a478bd7e92e64dcf
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/7104/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7297b3a69ccfc0a9ce9db083a478bd7e92e64dcf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] Java: fix git worktree compatibility

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Java: fix git worktree compatibility
......................................................................


Java: fix git worktree compatibility

The .git file is not a directory in git worktree checkouts.

A similar issue was fixed in thirdparty in 21f5ae0d53f9e.

Change-Id: I7297b3a69ccfc0a9ce9db083a478bd7e92e64dcf
Reviewed-on: http://gerrit.cloudera.org:8080/7104
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7297b3a69ccfc0a9ce9db083a478bd7e92e64dcf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Java: fix git worktree compatibility

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Java: fix git worktree compatibility
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7297b3a69ccfc0a9ce9db083a478bd7e92e64dcf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No