You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/10/20 13:56:29 UTC

Review Request 26923: CLOUDSTACK-7752: Management Server goes in infinite loop while creating a vm with tagged local data disk when the pool is not tagged

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26923/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Prachi Damle.


Repository: cloudstack-git


Description
-------

Fixed deployment planner stuck in infinite loop. If we create VM with shared service offering and attach disk with local disk offering, and one of storage pool is full(cannot be allocated) and other is not full then we are not putting the cluster in avoid list which is causing this infinite loop.
    
Fixed by putting the cluster in avoid list even if one of the storage pool is full(cannot be allocated)


Diffs
-----

  server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java bfb33b0 

Diff: https://reviews.apache.org/r/26923/diff/


Testing
-------

Deployed VM with different kind of scenarios. All deployment of VMs give expected result. scenarios tried

1. Deploy VM with default offering.
2. Deploy VM with data disk on local storage
3. Deploy VM with data disk on shared storage
4. Deployed VM with scenario mentioned in bug


Thanks,

Anshul Gangwar