You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "necouchman (via GitHub)" <gi...@apache.org> on 2023/10/29 18:30:26 UTC
[PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
necouchman opened a new pull request, #467:
URL: https://github.com/apache/guacamole-server/pull/467
Removes the reference to the non-existent `ssh_key.h` file, which breaks when you try to build with SSH agent support (`--enable-ssh-agent`).
Submitting this is a bug fix to 1.5.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-1989564077
Are there still issues with this PR? It looks pretty straightforward, and the issue appears to be still valid as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "Yugnk (via GitHub)" <gi...@apache.org>.
Yugnk commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-2253301230
I can't ssh with priv key. When I put the priv key in Guacamole. It doesn't connect. It gives the error "Log in failed. Please reconnect and try again."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-2253313510
@Yugnk This is not the place to ask that question - this is a (draft) pull request, not a mailing list or support forum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-1788787601
Converting to a draft for the moment - this needs a bit more work to fix the other issues that are present because of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-3218665486
Sorry @necouchman - looks like this and apache/guacamole-client#971 got auto-closed when I deleted the staging branch for 1.6.0 at release time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper closed pull request #467: GUACAMOLE-1658: Remove reference to non-existing ssh_key header.
URL: https://github.com/apache/guacamole-server/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "DenisVerkhovsky (via GitHub)" <gi...@apache.org>.
DenisVerkhovsky commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-2429515963
Hi,
Is there any update regarding the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper closed pull request #467: GUACAMOLE-1658: Remove reference to non-existing ssh_key header.
URL: https://github.com/apache/guacamole-server/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #467:
URL: https://github.com/apache/guacamole-server/pull/467#issuecomment-1989670815
@jmuehlner Yeah, unfortunately this is going to require re-implementing the overall SSH agent/key support that got removed. There are notes in the Jira issue - https://issues.apache.org/jira/browse/GUACAMOLE-1658.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1658: Remove reference to non-existing ssh_key header. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper closed pull request #467: GUACAMOLE-1658: Remove reference to non-existing ssh_key header.
URL: https://github.com/apache/guacamole-server/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org