You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2020/02/06 22:02:00 UTC
[jira] [Resolved] (THRIFT-5086) CMake target thrift::thrift has no
INTERFACE_INCLUDE_DIRECTORIES property
[ https://issues.apache.org/jira/browse/THRIFT-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer resolved THRIFT-5086.
--------------------------------
Resolution: Fixed
> CMake target thrift::thrift has no INTERFACE_INCLUDE_DIRECTORIES property
> -------------------------------------------------------------------------
>
> Key: THRIFT-5086
> URL: https://issues.apache.org/jira/browse/THRIFT-5086
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.13.0
> Reporter: SmartNet Club
> Assignee: SmartNet Club
> Priority: Major
> Fix For: 0.14.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> linking projects against thrift::thrift target failed due to missed INTERFACE_INCLUDE_DIRECTORIES property
> {code:java}
> // to fix apply patch
> diff --git a/build/cmake/ThriftMacros.cmake b/build/cmake/ThriftMacros.cmake
> index d068b2a..038651e 100644
> --- a/build/cmake/ThriftMacros.cmake
> +++ b/build/cmake/ThriftMacros.cmake
> @@ -25,6 +25,7 @@ endmacro(ADD_PKGCONFIG_THRIFT)
>
> macro(ADD_LIBRARY_THRIFT name)
> add_library(${name} ${ARGN})
> + target_include_directories(${name} INTERFACE $<INSTALL_INTERFACE:include>)
> set_target_properties(${name} PROPERTIES
> OUTPUT_NAME ${name}${THRIFT_RUNTIME_POSTFIX} # windows link variants (/MT, /MD, /MTd, /MDd) get different names
> VERSION ${thrift_VERSION} )
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)