You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/13 06:46:57 UTC
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3306: HDDS-6579. Add commandline argument for Container Info command.
adoroszlai commented on code in PR #3306:
URL: https://github.com/apache/ozone/pull/3306#discussion_r849132014
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -63,6 +63,11 @@ public class InfoSubcommand extends ScmSubcommand {
description = "Format output as JSON")
private boolean json;
+ @CommandLine.Option(names = { "--addReplicaDetails" },
Review Comment:
```suggestion
@CommandLine.Option(names = { "--replicas" },
```
##########
hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestInfoSubCommand.java:
##########
@@ -85,7 +85,7 @@ public void testReplicasIncludedInOutput() throws Exception {
.thenReturn(getReplicas());
cmd = new InfoSubcommand();
CommandLine c = new CommandLine(cmd);
- c.parseArgs("1");
+ c.parseArgs("1", "--addReplicaDetails");
Review Comment:
```suggestion
c.parseArgs("1", "--replicas");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org