You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/12/18 15:12:53 UTC
[GitHub] [nuttx] anchao opened a new pull request, #7916: net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
anchao opened a new pull request, #7916:
URL: https://github.com/apache/nuttx/pull/7916
## Summary
1. net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
2. Revert "mm/iob/contig: enhance iob contig to support iob chain"
use iob_pack instead of iob_contig
## Impact
N/A
## Testing
iperf test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7916: net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7916:
URL: https://github.com/apache/nuttx/pull/7916#discussion_r1051622758
##########
net/tcp/tcp_callback.c:
##########
@@ -258,12 +258,15 @@ uint16_t tcp_datahandler(FAR struct net_driver_s *dev,
iob_concat(conn->readahead, iob);
}
-#ifdef CONFIG_NET_TCP_RECV_CONTIG
+#ifdef CONFIG_NET_TCP_RECV_PACK
/* Merge an iob chain into a continuous space, thereby reducing iob
* consumption.
*/
- conn->readahead = iob_contig(conn->readahead);
+ if (conn->readahead->io_flink != NULL)
Review Comment:
why need check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #7916: net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7916:
URL: https://github.com/apache/nuttx/pull/7916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #7916: net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7916:
URL: https://github.com/apache/nuttx/pull/7916#discussion_r1051623857
##########
net/tcp/tcp_callback.c:
##########
@@ -258,12 +258,15 @@ uint16_t tcp_datahandler(FAR struct net_driver_s *dev,
iob_concat(conn->readahead, iob);
}
-#ifdef CONFIG_NET_TCP_RECV_CONTIG
+#ifdef CONFIG_NET_TCP_RECV_PACK
/* Merge an iob chain into a continuous space, thereby reducing iob
* consumption.
*/
- conn->readahead = iob_contig(conn->readahead);
+ if (conn->readahead->io_flink != NULL)
Review Comment:
If it is not chain and does not need pack, reduce copy once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org