You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/02 08:45:37 UTC

[GitHub] [kafka] dengziming commented on a diff in pull request #12467: KAFKA-14129: KRaft must check manual assignments for createTopics are contiguous

dengziming commented on code in PR #12467:
URL: https://github.com/apache/kafka/pull/12467#discussion_r935283700


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -81,6 +81,8 @@ class BrokerServer(
   val controllerQuorumVotersFuture: CompletableFuture[util.Map[Integer, AddressSpec]]
 ) extends KafkaBroker {
 
+  val lifecycleManager: BrokerLifecycleManager = new BrokerLifecycleManager(config, time, threadNamePrefix)

Review Comment:
   This change will make some tests fail since `lifecycleManager` is stateful(for example, initialCatchUpFuture ) but we are stopping and restarting it in `LeaderElectionCommandTest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org