You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:36:18 UTC

[GitHub] [skywalking] mikkeschiren opened a new issue #4453: Add the possibilty to search for URL, not just Endpoint

mikkeschiren opened a new issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [X] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   - Add the possibilty to serach for URL, not just endpoint.
   
   When having an application with "messy URLs" it makes sense to have the possibility to search for URLs, not just endpoints.
   
   ![bild](https://user-images.githubusercontent.com/712838/76092698-23f77180-5fc0-11ea-8d67-74848f325099.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595797905
 
 
   When I search for URL in Endpoint - I do not get any results though - is this in 7.0.0 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595805607
 
 
   Try `/play/api/media`, you could search the endpoint from dashboard page first, to check whether it is already there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595816025
 
 
   Yeah - all parameters - so if I have an endpoint, as my example /play/api/media I would like the possibility to search for the parameter `types`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren opened a new issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren opened a new issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [X] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   - Add the possibility to search for URL, not just endpoint.
   
   When having an application with "messy URLs" it makes sense to have the possibility to search for URLs, not just endpoints.
   
   ![bild](https://user-images.githubusercontent.com/712838/76092698-23f77180-5fc0-11ea-8d67-74848f325099.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595814617
 
 
   Oh, do you mean all parameter or specific ones?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595796546
 
 
   Endpoint is including the URL. Read the core concept doc, https://github.com/apache/skywalking/blob/master/docs/en/concepts-and-designs/overview.md#why-use-skywalking

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595820739
 
 
   First of all, you should not consider add all parameters, because that will make the endpoint number increasing out of control. We assume the endpoint number is limited and run the aggregation on it.
   Second, even for explicit parameter names, such as `types` only, you should consider to discuss this on the agent repo. From my understanding, you are not using Java agent, maybe PHP? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595812811
 
 
   Yeah - that is there - but maybe I am phrasing myself wrong here - I would like a feature to be able to search for parameters in the url.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng closed issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng closed issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-596460451
 
 
   Ok, I will do some own digging into this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
mikkeschiren commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595799089
 
 
   ![bild](https://user-images.githubusercontent.com/712838/76093396-2d350e00-5fc1-11ea-82dd-d7a9b57f5803.png)
   
   
   ![bild](https://user-images.githubusercontent.com/712838/76093467-4c33a000-5fc1-11ea-9c8a-36ec565f1ff2.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4453: Add the possibilty to search for URL, not just Endpoint
URL: https://github.com/apache/skywalking/issues/4453#issuecomment-595805332
 
 
   My guess, the parameter is not included. It is URI so get parameter should be excluded. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services